Django

Code

Ticket #3322 (closed: fixed)

Opened 2 years ago

Last modified 2 years ago

[patch] UnicodeCursorWrapper does not accept dict-style format objects

Reported by: kurtiss@meetro.com Assigned to: adrian
Milestone: Component: Database layer (models, ORM)
Version: SVN Keywords: unicode-branch
Cc: kurtiss@meetro.com, mir@noris.de Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Django supports pyformat style format parameters (eg. http://code.djangoproject.com/changeset/3038). The change intended to add unicode support for postgresql queries restricts format objects to lists and tuples. The following patch reinstates dict format object passing.

Attachments

pyformat_psql.diff (1.2 kB) - added by kurtiss@meetro.com on 01/18/07 12:34:48.
Reissues support for pyformat style format parameters using postgresql's UnicodeCursorWrapper?

Change History

01/18/07 12:34:48 changed by kurtiss@meetro.com

  • attachment pyformat_psql.diff added.

Reissues support for pyformat style format parameters using postgresql's UnicodeCursorWrapper?

02/11/07 12:35:02 changed by Michael Radziej <mir@noris.de>

  • cc changed from kurtiss@meetro.com to kurtiss@meetro.com, mir@noris.de.
  • needs_better_patch changed.
  • needs_tests changed.
  • needs_docs changed.

05/14/07 05:45:55 changed by mtredinnick

  • keywords set to unicode-branch.
  • stage changed from Unreviewed to Accepted.

Due to some refactoring that has gone on in the unicode branch that will soon change the code referred to in this patch, I am going to commit a modified version of this patch to the unicode branch and then close this ticket when that is merged back into trunk.

Note that this bug only affects the postgresl (psycopg1) backend.

05/14/07 05:48:25 changed by mtredinnick

(In [5227]) Reintroduced support for parameter dictionaries when using the PostgreSQL psycopg1 backend directly. Refs #3322. Based on a patch from kurtiss@meetro.com.

07/04/07 07:11:05 changed by mtredinnick

  • status changed from new to closed.
  • resolution set to fixed.

(In [5609]) Merged Unicode branch into trunk (r4952:5608). This should be fully backwards compatible for all practical purposes.

Fixed #2391, #2489, #2996, #3322, #3344, #3370, #3406, #3432, #3454, #3492, #3582, #3690, #3878, #3891, #3937, #4039, #4141, #4227, #4286, #4291, #4300, #4452, #4702

Add/Change #3322 ([patch] UnicodeCursorWrapper does not accept dict-style format objects)




Change Properties
Action