Django

Code

Ticket #8959 (closed: fixed)

Opened 2 months ago

Last modified 2 months ago

Remove calls to escape in new comments framework templates

Reported by: zgoda Assigned to: adrian
Milestone: post-1.0 Component: django.contrib.comments
Version: SVN Keywords:
Cc: Triage Stage: Accepted
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

As autoescaping is in place with current Django, escaping values in templates is not necessary. Attached patch fixes this.

Attachments

contrib-comments-escaping.diff (5.2 kB) - added by zgoda on 09/08/08 02:07:29.
Removing calls to escape in templates

Change History

09/08/08 02:07:29 changed by zgoda

  • attachment contrib-comments-escaping.diff added.

Removing calls to escape in templates

09/08/08 12:41:23 changed by thejaswi_puthraya

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

True, but I don't see anything wrong with keeping it on. It's better to be safe than never. Marking it DDN for some core-devs to comment on this.

09/08/08 13:44:40 changed by zgoda

Sure, nothing wrong. It's just for consistency.

09/08/08 16:28:45 changed by adrian

  • owner changed from nobody to adrian.
  • status changed from new to assigned.
  • stage changed from Design decision needed to Accepted.

It's worth removing those unnecessary "escape" filters, given that they're redundant and cause a slight be of extra overhead. I will review and check in the patch.

09/10/08 00:14:59 changed by adrian

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [9000]) Fixed #8959 -- Removed redundant calls to the 'escape' template filter in the django.contrib.comments templates. Thanks, zgoda

Add/Change #8959 (Remove calls to escape in new comments framework templates)




Change Properties
Action